[ https://issues.apache.org/jira/browse/HIVE-16328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963701#comment-15963701 ]
Hive QA commented on HIVE-16328: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12862755/HIVE-16328.2.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 10570 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr] (batchId=143) org.apache.hive.jdbc.TestJdbcDriver2.testResultSetMetaData (batchId=221) org.apache.hive.jdbc.TestMultiSessionsHS2WithLocalClusterSpark.testSparkQuery (batchId=223) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4632/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4632/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4632/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 3 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12862755 - PreCommit-HIVE-Build > HoS: more aggressive mapjoin optimization when > hive.spark.use.file.size.for.mapjoin is true > ------------------------------------------------------------------------------------------- > > Key: HIVE-16328 > URL: https://issues.apache.org/jira/browse/HIVE-16328 > Project: Hive > Issue Type: Bug > Components: Logical Optimizer > Reporter: Chao Sun > Assignee: Chao Sun > Attachments: HIVE-16328.1.patch, HIVE-16328.2.patch > > > In HIVE-15489, when {{hive.spark.use.file.size.for.mapjoin}} is set to true, > and if the JOIN op has any upstream RS operator, then we will stop converting > the JOIN op to MAPJOIN op. > However, this is overly conservative. A better solution is to treat the > branch that has upstream RS as the big table and check if all other branches > are map-only AND can fit in hash table size. -- This message was sent by Atlassian JIRA (v6.3.15#6346)