[ https://issues.apache.org/jira/browse/HIVE-16311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958408#comment-15958408 ]
Matt McCline edited comment on HIVE-16311 at 4/6/17 6:57 AM: ------------------------------------------------------------- Ok, it looks like you have added a new member (fastTrailingZeroes) to FastDecimal so I do need to step in and figure out what is going on and why this is necessary. If OldHiveDecimal is not a reference for behavior, then it seems like we need to develop a new behavior standard test data we can test against. Perhaps a triple list of random decimal1, random decimal2, and the standard expected result. was (Author: mmccline): Ok, it looks like you have added a new member (fastTrailingZeroes) to FastDecimal so I do need to step in and figure out what is going on and why this is necessary. > Improve the performance for FastHiveDecimalImpl.fastDivide > ---------------------------------------------------------- > > Key: HIVE-16311 > URL: https://issues.apache.org/jira/browse/HIVE-16311 > Project: Hive > Issue Type: Improvement > Affects Versions: 2.2.0 > Reporter: Colin Ma > Assignee: Colin Ma > Fix For: 3.0.0 > > Attachments: HIVE-16311.001.patch, HIVE-16311.002.patch, > HIVE-16311.003.patch, HIVE-16311.004.patch, HIVE-16311.005.patch, > HIVE-16311.withTrailingZero.patch > > > FastHiveDecimalImpl.fastDivide is poor performance when evaluate the > expression as 12345.67/123.45 > There are 2 points can be improved: > 1. Don't always use HiveDecimal.MAX_SCALE as scale when do the > BigDecimal.divide. > 2. Get the precision for BigInteger in a fast way if possible. -- This message was sent by Atlassian JIRA (v6.3.15#6346)