[ https://issues.apache.org/jira/browse/HIVE-16346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954591#comment-15954591 ]
Hive QA commented on HIVE-16346: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12861786/HIVE-16346.2.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 37 failed/errored test(s), 10574 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[drop_with_concurrency] (batchId=234) org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[escape_comments] (batchId=234) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr] (batchId=142) org.apache.hive.hcatalog.streaming.TestStreaming.testAddPartition (batchId=186) org.apache.hive.hcatalog.streaming.TestStreaming.testBucketing (batchId=186) org.apache.hive.hcatalog.streaming.TestStreaming.testBucketingWhereBucketColIsNotFirstCol (batchId=186) org.apache.hive.hcatalog.streaming.TestStreaming.testConcurrentTransactionBatchCommits (batchId=186) org.apache.hive.hcatalog.streaming.TestStreaming.testEndpointConnection (batchId=186) org.apache.hive.hcatalog.streaming.TestStreaming.testErrorHandling (batchId=186) org.apache.hive.hcatalog.streaming.TestStreaming.testFileDump (batchId=186) org.apache.hive.hcatalog.streaming.TestStreaming.testFileDumpCorruptDataFiles (batchId=186) org.apache.hive.hcatalog.streaming.TestStreaming.testFileDumpCorruptSideFiles (batchId=186) org.apache.hive.hcatalog.streaming.TestStreaming.testHeartbeat (batchId=186) org.apache.hive.hcatalog.streaming.TestStreaming.testInterleavedTransactionBatchCommits (batchId=186) org.apache.hive.hcatalog.streaming.TestStreaming.testMultipleTransactionBatchCommits (batchId=186) org.apache.hive.hcatalog.streaming.TestStreaming.testRemainingTransactions (batchId=186) org.apache.hive.hcatalog.streaming.TestStreaming.testStreamBucketingMatchesRegularBucketing (batchId=186) org.apache.hive.hcatalog.streaming.TestStreaming.testTableValidation (batchId=186) org.apache.hive.hcatalog.streaming.TestStreaming.testTimeOutReaper (batchId=186) org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchAbort (batchId=186) org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchAbortAndCommit (batchId=186) org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchCommit_Delimited (batchId=186) org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchCommit_DelimitedUGI (batchId=186) org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchCommit_Json (batchId=186) org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchCommit_Regex (batchId=186) org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchCommit_RegexUGI (batchId=186) org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchEmptyAbort (batchId=186) org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchEmptyCommit (batchId=186) org.apache.hive.hcatalog.streaming.mutate.TestMutations.testMulti (batchId=186) org.apache.hive.hcatalog.streaming.mutate.TestMutations.testTransactionBatchAbort (batchId=186) org.apache.hive.hcatalog.streaming.mutate.TestMutations.testTransactionBatchCommitPartitioned (batchId=186) org.apache.hive.hcatalog.streaming.mutate.TestMutations.testTransactionBatchCommitUnpartitioned (batchId=186) org.apache.hive.hcatalog.streaming.mutate.TestMutations.testTransactionBatchEmptyAbortPartitioned (batchId=186) org.apache.hive.hcatalog.streaming.mutate.TestMutations.testTransactionBatchEmptyAbortUnartitioned (batchId=186) org.apache.hive.hcatalog.streaming.mutate.TestMutations.testTransactionBatchEmptyCommitPartitioned (batchId=186) org.apache.hive.hcatalog.streaming.mutate.TestMutations.testTransactionBatchEmptyCommitUnpartitioned (batchId=186) org.apache.hive.hcatalog.streaming.mutate.TestMutations.testUpdatesAndDeletes (batchId=186) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4531/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4531/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4531/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 37 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12861786 - PreCommit-HIVE-Build > inheritPerms should be conditional based on the target filesystem > ----------------------------------------------------------------- > > Key: HIVE-16346 > URL: https://issues.apache.org/jira/browse/HIVE-16346 > Project: Hive > Issue Type: Sub-task > Reporter: Sahil Takiar > Assignee: Sahil Takiar > Attachments: HIVE-16346.1.patch, HIVE-16346.2.patch > > > Right now, a lot of the logic in {{Hive.java}} attempts to set permissions of > different files that have been moved / copied. This is only triggered if > {{hive.warehouse.subdir.inherit.perms}} is set to true. > However, on blobstores such as S3, there is no concept of file permissions so > these calls are unnecessary and can could a performance impact. > One solution would be to set {{hive.warehouse.subdir.inherit.perms}} to > false, but this would be a global change that affects an entire HS2 instance. > So HDFS tables will no longer have permissions inheritance. > A better solution would be to make the inheritance of permissions conditional > on the target filesystem. -- This message was sent by Atlassian JIRA (v6.3.15#6346)