[
https://issues.apache.org/jira/browse/HIVE-15935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15883706#comment-15883706
]
Siddharth Seth commented on HIVE-15935:
---------------------------------------
{code}
requestuser = hookContext.getUgi().getUserName() ;
{code}
Should this be getShortUserName? I'm not absolutely sure this line is even
requried. Afaik, the UGI in hookcontext will be the longUser. Don't see harm in
leaving it though.
May want to PerfLog the ATS putDomain - blocking call, which can take some time.
setupDomain can take time, and should not be inline with the ATSHook.run. ATS
event publishing is already in background threads for the same reason. Also
timelinelineclient is only setup after setupAtsExecutor(conf); - I believe the
patch will fai with an NPEl at the moment.
> ACL is not set in ATS data
> --------------------------
>
> Key: HIVE-15935
> URL: https://issues.apache.org/jira/browse/HIVE-15935
> Project: Hive
> Issue Type: Bug
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Attachments: HIVE-15935.1.patch, HIVE-15935.2.patch,
> HIVE-15935.3.patch, HIVE-15935.4.patch
>
>
> When publishing ATS info, Hive does not set ACL, that make Hive ATS entries
> visible to all users. On the other hand, Tez ATS entires is using Tez DAG ACL
> which limit both view/modify ACL to end user only. We shall make them
> consistent. In the Jira, I am going to limit ACL to end user for both Tez ATS
> and Hive ATS, also provide config "hive.view.acls" and "hive.modify.acls" if
> user need to overridden.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
