[ https://issues.apache.org/jira/browse/HIVE-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15883099#comment-15883099 ]
Aihua Xu commented on HIVE-13864: --------------------------------- The logic seems good that we are carrying the quote info from the previous line to the next line. But I feel a little confusing to use array to pass the single value and also we are really tracking if a char is within quotes (string), not really escape. Minor suggestions to make the code more readable: 1. can you add some comments to the function and some lines to explain what you are doing? 2. Check to see if you can use {{Character startQuote}} to carry such info and use Character.unsigned or a special value to mean it's unset? > Beeline ignores the command that follows a semicolon and comment > ---------------------------------------------------------------- > > Key: HIVE-13864 > URL: https://issues.apache.org/jira/browse/HIVE-13864 > Project: Hive > Issue Type: Bug > Reporter: Muthu Manickam > Assignee: Yongzhi Chen > Attachments: HIVE-13864.01.patch, HIVE-13864.02.patch, > HIVE-13864.3.patch, HIVE-13864.4.patch > > > Beeline ignores the next line/command that follows a command with semicolon > and comments. > Example 1: > select * > from table1; -- comments > select * from table2; > In this case, only the first command is executed.. second command "select * > from table2" is not executed. > ------ > Example 2: > select * > from table1; -- comments > select * from table2; > select * from table3; > In this case, first command and third command is executed. second command > "select * from table2" is not executed. -- This message was sent by Atlassian JIRA (v6.3.15#6346)