[
https://issues.apache.org/jira/browse/HIVE-16006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881988#comment-15881988
]
Sushanth Sowmyan edited comment on HIVE-16006 at 2/24/17 5:24 AM:
------------------------------------------------------------------
[~sankarh], good catch on the issue for the target name difference. Your change
to ReplicationSemanticAnalyzer.java is very much on-point.
However, the other change, to ImportSemanticAnalyzer will break current replv1,
as the expectation of repl-import is very much a replace, not an insert-into.
This is a case for expanding ReplicationSpec with an additional .isInsert()
semantic that defaults to false, but in the cases of INSERT events, can be
true, and when we instantiate the ReplicationSpec object to pass in, we'll set
that.
Also, could you please expand on the tests in TestReplicationScenarios when
fixing these bugs? That helps us make sure we don't regress on this in the
future due to some other edit.
was (Author: sushanth):
[~sankarh], good catch on the issue for the target name difference. Your change
to ReplicationSemanticAnalyzer.java is very much on-point.
However, the other change, to ImportSemanticAnalyzer will break current replv1,
as the expectation of repl-import is very much a replace, not an insert-into.
This is a case for expanding ReplicationSpec with an additional .isInsert()
semantic that defaults to false, but in the cases of INSERT events, can be true.
Also, could you please expand on the tests in TestReplicationScenarios when
fixing these bugs? That helps us make sure we don't regress on this in the
future due to some other edit.
> Incremental REPL LOAD doesn't operate on the target database if name differs
> from source database.
> --------------------------------------------------------------------------------------------------
>
> Key: HIVE-16006
> URL: https://issues.apache.org/jira/browse/HIVE-16006
> Project: Hive
> Issue Type: Sub-task
> Components: repl
> Reporter: Sankar Hariappan
> Assignee: Sankar Hariappan
> Attachments: HIVE-16006.01.patch
>
>
> During "Incremental Load", it is not considering the database name input in
> the command line. Hence load doesn't happen. At the same time, database with
> original name is getting modified.
> Steps:
> 1. REPL DUMP default FROM 52;
> 2. REPL LOAD replDb FROM '/tmp/dump/1487588522621';
> – This step modifies the default Db instead of replDb.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
