[
https://issues.apache.org/jira/browse/HIVE-15691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864761#comment-15864761
]
Roshan Naik edited comment on HIVE-15691 at 2/14/17 12:39 AM:
--------------------------------------------------------------
[~ekoifman] & [~kalyanhadoop]
1) I think the class needs only 2 constructors:
- StrictRegexWriter(String regex, HiveEndPoint endPoint)
- StrictRegexWriter(String regex, HiveEndPoint endPoint, HiveConf conf)
The 'connection' param should be eliminated.
2) I cannot say much about the correctness of createSerde() & encode() methods,
as i have not worked with RegexSerDe. Would be good to know if this has been
validated via a manual test where the data streamed via this writer, was
properly queryable from Hive.
Looks fine other than that.
was (Author: roshan_naik):
[~ekoifman] & [~kalyanhadoop]
1) I think the class needs only 2 constructors:
- StrictRegexWriter(String regex, HiveEndPoint endPoint)
- StrictRegexWriter(String regex, HiveEndPoint endPoint, HiveConf conf)
The 'connection' param should be eliminated.
2) I cannot say much about the correctness of createSerde() & encode() methods,
as i have not worked with RegexSerDe. Would be good to know if this has been
validated via a manual test where the data streamed via this writer, was
properly queryable from Hive.
> Create StrictRegexWriter to work with RegexSerializer for Flume Hive Sink
> -------------------------------------------------------------------------
>
> Key: HIVE-15691
> URL: https://issues.apache.org/jira/browse/HIVE-15691
> Project: Hive
> Issue Type: New Feature
> Components: HCatalog, Transactions
> Reporter: Kalyan
> Assignee: Kalyan
> Attachments: HIVE-15691.1.patch, HIVE-15691.patch,
> HIVE-15691-updated.patch
>
>
> Create StrictRegexWriter to work with RegexSerializer for Flume Hive Sink.
> It is similar to StrictJsonWriter available in hive.
> Dependency is there in flume to commit.
> FLUME-3036 : Create a RegexSerializer for Hive Sink.
> Patch is available for Flume, Please verify the below link
> https://github.com/kalyanhadooptraining/flume/commit/1c651e81395404321f9964c8d9d2af6f4a2aaef9
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
