[ https://issues.apache.org/jira/browse/HIVE-15849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858010#comment-15858010 ]
Hive QA commented on HIVE-15849: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12851620/HIVE-15832.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 10241 tests executed *Failed tests:* {noformat} TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out) (batchId=235) org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_join_with_different_encryption_keys] (batchId=159) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] (batchId=223) org.apache.hadoop.hive.metastore.TestMarkPartitionRemote.testMarkingPartitionSet (batchId=203) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3439/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3439/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3439/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 4 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12851620 - PreCommit-HIVE-Build > hplsql should add enterGlobalScope func to UDF > ---------------------------------------------- > > Key: HIVE-15849 > URL: https://issues.apache.org/jira/browse/HIVE-15849 > Project: Hive > Issue Type: Bug > Components: hpl/sql > Affects Versions: 2.2.0 > Reporter: Fei Hui > Assignee: Fei Hui > Attachments: HIVE-15832.patch > > > code in Udf.java > {quote} > if (exec == null) { > exec = new Exec(); > exec.enterGlobalScope(); > String query = queryOI.getPrimitiveJavaObject(arguments[0].get()); > String[] args = { "-e", query, "-trace" }; > try { > exec.setUdfRun(true); > exec.init(args); > } catch (Exception e) { > throw new HiveException(e.getMessage()); > } > } > if (arguments.length > 1) { > setParameters(arguments); > } > Var result = exec.run(); > if (result != null) { > return result.toString(); > } > {quote} > we should add 'exec.enterGlobalScope(); ' before set parameters > before fixing this > we get the wrong result, result contains empty string > Starting pre-SQL statement > Starting pre-SQL statement > Starting pre-SQL statement > Starting pre-SQL statement > Starting pre-SQL statement > Starting query > Query executed successfully (2.30 sec) > Ln:8 SELECT completed successfully > Ln:8 Standalone SELECT executed: 1 columns in the result set > Hello, ! > Hello, ! > after fixing it > we get the right result > Starting pre-SQL statement > Starting pre-SQL statement > Starting pre-SQL statement > Starting pre-SQL statement > Starting pre-SQL statement > Starting query > Query executed successfully (2.35 sec) > Ln:8 SELECT completed successfully > Ln:8 Standalone SELECT executed: 1 columns in the result set > Hello, fei! > Hello, fei! > tests come from HIVE-15832 -- This message was sent by Atlassian JIRA (v6.3.15#6346)