[ https://issues.apache.org/jira/browse/HIVE-15573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834002#comment-15834002 ]
Hive QA commented on HIVE-15573: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12848836/HIVE-15573.02.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 13 failed/errored test(s), 10990 tests executed *Failed tests:* {noformat} TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out) (batchId=235) org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_join_with_different_encryption_keys] (batchId=159) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[dynpart_sort_opt_vectorization] (batchId=148) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[dynpart_sort_optimization2] (batchId=139) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[mergejoin] (batchId=150) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[offset_limit_ppd_optimizer] (batchId=151) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vec_part] (batchId=149) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_groupby4] (batchId=141) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_groupby6] (batchId=154) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_groupby_reduce] (batchId=149) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorized_ptf] (batchId=150) org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainuser_3] (batchId=93) org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[vectorization_limit] (batchId=93) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3124/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3124/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3124/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 13 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12848836 - PreCommit-HIVE-Build > Vectorization: ACID shuffle ReduceSink is not specialized > ---------------------------------------------------------- > > Key: HIVE-15573 > URL: https://issues.apache.org/jira/browse/HIVE-15573 > Project: Hive > Issue Type: Improvement > Components: Transactions, Vectorization > Affects Versions: 2.2.0 > Reporter: Gopal V > Assignee: Matt McCline > Fix For: 2.2.0 > > Attachments: HIVE-15573.01.patch, HIVE-15573.02.patch, > screenshot-1.png > > > The ACID shuffle disabled murmur hash for the shuffle, due to the bucketing > requirements demanding the writable hashcode for the shuffles. > {code} > boolean useUniformHash = desc.getReducerTraits().contains(UNIFORM); > if (!useUniformHash) { > return false; > } > {code} > This check protects the fast ReduceSink ops from being used in ACID inserts. > A specialized case for the following pattern will make ACID insert much > faster. > {code} > Reduce Output Operator > sort order: > Map-reduce partition columns: _col0 (type: bigint) > value expressions: .... > {code} > !screenshot-1.png! -- This message was sent by Atlassian JIRA (v6.3.4#6332)