[ https://issues.apache.org/jira/browse/HIVE-15442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15753737#comment-15753737 ]
Hive QA commented on HIVE-15442: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12843543/HIVE-15442.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 12 failed/errored test(s), 10818 tests executed *Failed tests:* {noformat} TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out) (batchId=234) TestVectorizedColumnReaderBase - did not produce a TEST-*.xml file (likely timed out) (batchId=251) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample2] (batchId=5) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample4] (batchId=15) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample6] (batchId=61) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample7] (batchId=60) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample9] (batchId=38) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_sort_array] (batchId=59) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[transform_ppr2] (batchId=135) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[metadataonly1] (batchId=150) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[stats_based_fetch_decision] (batchId=151) org.apache.hive.jdbc.TestMultiSessionsHS2WithLocalClusterSpark.testSparkQuery (batchId=216) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/2605/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/2605/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-2605/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 12 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12843543 - PreCommit-HIVE-Build > Driver.java has a redundancy code > ---------------------------------- > > Key: HIVE-15442 > URL: https://issues.apache.org/jira/browse/HIVE-15442 > Project: Hive > Issue Type: Bug > Affects Versions: 2.1.1 > Reporter: Gold huang > Assignee: Gold huang > Priority: Minor > Attachments: HIVE-15442.patch > > > Driver.java has a redundancy code,i think the third if statement could be > remved. > if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT)) { > String explainOutput = getExplainOutput(sem, plan, tree.dump()); > if (explainOutput != null) { > if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT)) { > LOG.info("EXPLAIN output for queryid " + queryId + " : " + > explainOutput); > } > if (conf.isWebUiQueryInfoCacheEnabled()) { > queryDisplay.setExplainPlan(explainOutput); > } > } > } -- This message was sent by Atlassian JIRA (v6.3.4#6332)