[ https://issues.apache.org/jira/browse/HIVE-12504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15723019#comment-15723019 ]
Wei Zheng commented on HIVE-12504: ---------------------------------- Patch looks good. General question, when do we need to call ensureValidTxn? Do we need it in abortTxns for example? nit: I think the import in TxnHandler is not needed there. > TxnHandler.abortTxn() should check if already aborted to improve message > ------------------------------------------------------------------------ > > Key: HIVE-12504 > URL: https://issues.apache.org/jira/browse/HIVE-12504 > Project: Hive > Issue Type: Bug > Components: Transactions > Affects Versions: 1.0.0 > Reporter: Eugene Koifman > Assignee: Eugene Koifman > Attachments: HIVE-12504.01.patch, HIVE-12504.patch > > > If the update statement misses, it would be useful for abortTxn() to > run another query to see if the requested txnid is in Aborted state to > improve error msg. > Note: get a separate read_committed connection for this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)