[ https://issues.apache.org/jira/browse/HIVE-14582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15687180#comment-15687180 ]
Ashutosh Chauhan commented on HIVE-14582: ----------------------------------------- Patch looks good. Any reason you restricted scale argument to be constant? Your evaluate method supports it, but you throw exception for non-constants in initialize(). Date version already supports it, so we should consider supporting it for numerics too. Will enable queries like: create table t1(c double, d int); select trunc (c,d) from t1; > Add trunc(numeric) udf > ---------------------- > > Key: HIVE-14582 > URL: https://issues.apache.org/jira/browse/HIVE-14582 > Project: Hive > Issue Type: Sub-task > Components: SQL > Reporter: Ashutosh Chauhan > Assignee: Chinna Rao Lalam > Attachments: HIVE-14582.1.patch, HIVE-14582.2.patch, > HIVE-14582.3.patch, HIVE-14582.patch > > > https://docs.oracle.com/cd/B19306_01/server.102/b14200/functions200.htm -- This message was sent by Atlassian JIRA (v6.3.4#6332)