[ 
https://issues.apache.org/jira/browse/HIVE-14910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15605352#comment-15605352
 ] 

Barna Zsombor Klara commented on HIVE-14910:
--------------------------------------------

I'll steal this one [~sseth] if you don't mind.
I ran into this one today and had a look at it. I think the failure is coming 
from this race condition: the listener can be added to the JobHandle only after 
the job has been submitted. So there is no guarantee that every method of the 
listener will be invoked, some state changes may have happened before the 
caller received the handler back.

I propose a slight change in the API (because fixing the test is I think not 
possible). We should add the listeners as an argument of the submit method, so 
we can set them on the Handler before the job itself is submitted. In my 
opinion having a listener with methods which may or may not be invoked 
depending on a race condition is a problem anyway.

> Flaky test: TestSparkClient.testJobSubmission
> ---------------------------------------------
>
>                 Key: HIVE-14910
>                 URL: https://issues.apache.org/jira/browse/HIVE-14910
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Siddharth Seth
>
> Have seen this fail in multiple runs (not consistently)
> e.g. https://builds.apache.org/job/PreCommit-HIVE-Build/1426/testReport/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to