[ 
https://issues.apache.org/jira/browse/HIVE-14721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15566918#comment-15566918
 ] 

Siddharth Seth commented on HIVE-14721:
---------------------------------------

The patch looks good. +1. Minor comments: Should the additional debug 
statements be removed ?

Looks like we still have quite a few flaky tests. I don't think any of the 
changes affect the failing tests. TestSparkClient.testJobSubmission is a known 
flaky test. Could you please verify the remaining 3 tests locally before 
committing.

> Fix TestJdbcWithMiniHS2 runtime
> -------------------------------
>
>                 Key: HIVE-14721
>                 URL: https://issues.apache.org/jira/browse/HIVE-14721
>             Project: Hive
>          Issue Type: Sub-task
>    Affects Versions: 2.1.0
>            Reporter: Vaibhav Gumashta
>            Assignee: Vaibhav Gumashta
>         Attachments: HIVE-14721.1.patch, HIVE-14721.2.patch, 
> HIVE-14721.3.patch, HIVE-14721.3.patch, HIVE-14721.3.patch, 
> HIVE-14721.4.patch, HIVE-14721.4.patch, HIVE-14721.5.patch, 
> HIVE-14721.6.patch, HIVE-14721.6.patch, HIVE-14721.6.patch
>
>
> Currently 450s



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to