[
https://issues.apache.org/jira/browse/HIVE-13966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524561#comment-15524561
]
Alan Gates commented on HIVE-13966:
-----------------------------------
I'd like to work on getting this patch committed. I haven't finished reviewing
it yet but I have one question from what I've seen so far. Why create a new
interface TransactionalMetaStoreEventListener? Based on the changes in the
config file the system will no which event listener to put in this group so I'm
not sure what the different interface buys us.
> DbNotificationListener: can loose DDL operation notifications
> -------------------------------------------------------------
>
> Key: HIVE-13966
> URL: https://issues.apache.org/jira/browse/HIVE-13966
> Project: Hive
> Issue Type: Bug
> Components: HCatalog
> Reporter: Nachiket Vaidya
> Assignee: Rahul Sharma
> Priority: Critical
> Attachments: HIVE-13966.1.patch, HIVE-13966.2.patch, HIVE-13966.pdf
>
>
> The code for each API in HiveMetaStore.java is like this:
> 1. openTransaction()
> 2. -- operation--
> 3. commit() or rollback() based on result of the operation.
> 4. add entry to notification log (unconditionally)
> If the operation is failed (in step 2), we still add entry to notification
> log. Found this issue in testing.
> It is still ok as this is the case of false positive.
> If the operation is successful and adding to notification log failed, the
> user will get an MetaException. It will not rollback the operation, as it is
> already committed. We need to handle this case so that we will not have false
> negatives.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
