[ https://issues.apache.org/jira/browse/HIVE-14451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15459958#comment-15459958 ]
Sergey Shelukhin commented on HIVE-14451: ----------------------------------------- Some comments on RB, mostly about documentation. One question - is this supposed to also apply to BytesBytes... hashtable? > Vectorization: Add byRef mode for borrowed Strings in VectorDeserializeRow > -------------------------------------------------------------------------- > > Key: HIVE-14451 > URL: https://issues.apache.org/jira/browse/HIVE-14451 > Project: Hive > Issue Type: Improvement > Components: Vectorization > Reporter: Gopal V > Assignee: Matt McCline > Attachments: HIVE-14451.01.patch, HIVE-14451.02.patch, > HIVE-14451.03.patch > > > In a majority of cases, when using the OptimizedHashMap, the references to > the byte[] are immutable. > The hashmap result always allocates on boundary conditions, but never mutates > a previous buffer. > Copying Strings out of the hashtable is entirely wasteful and it would be > easy to know when the currentBytes is a borrowed slice from the original > input. -- This message was sent by Atlassian JIRA (v6.3.4#6332)