[ https://issues.apache.org/jira/browse/HIVE-14589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15450456#comment-15450456 ]
Hive QA commented on HIVE-14589: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12826233/HIVE-14589.02.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 10472 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.org.apache.hadoop.hive.cli.TestCliDriver org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_join_part_col_char] org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainuser_3] org.apache.hadoop.hive.ql.TestMTQueries.testMTQueries1 org.apache.hive.jdbc.TestJdbcWithMiniHS2.testAddJarConstructorUnCaching {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/1046/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/1046/console Test logs: http://ec2-204-236-174-241.us-west-1.compute.amazonaws.com/logs/PreCommit-HIVE-MASTER-Build-1046/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 5 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12826233 - PreCommit-HIVE-MASTER-Build > add consistent node replacement to LLAP for splits > -------------------------------------------------- > > Key: HIVE-14589 > URL: https://issues.apache.org/jira/browse/HIVE-14589 > Project: Hive > Issue Type: Bug > Reporter: Sergey Shelukhin > Assignee: Sergey Shelukhin > Attachments: HIVE-14589.01.patch, HIVE-14589.02.patch, > HIVE-14589.patch > > > See HIVE-14574. (copied from the comment below) This basically creates the > nodes in ZK for "slots" in the cluster. The LLAPs try to take the lowest > available slot, starting from 0. Unlike worker-... nodes, the slots are > reused, which is the intent. The LLAPs are always sorted by the slot number > for splits. > The idea is that as long as LLAP is running, it will retain the same position > in the ordering, regardless of other LLAPs restarting, without knowing about > each other, the predecessors location (if restarted in a different place), or > the total size of the cluster. > The restarting LLAPs may not take the same positions as their predecessors > (i.e. if two LLAPs restart they can swap slots) but it shouldn't matter > because they have lost their cache anyway. > I.e. if you have LLAPs with slots 1-2-3-4 and I nuke and restart 1, 2, and 4, > they will take whatever slots, but 3 will stay the 3rd and retain cache > locality. > This also handles size increase, as new LLAPs will always be added to the end > of the sequence, which is what consistent hashing needs. > One case it doesn't handle is permanent cluster size reduction. There will be > a permanent gap if LLAPs are removed that have the slots in the middle; until > some are restarted, it will result in misses -- This message was sent by Atlassian JIRA (v6.3.4#6332)