[ 
https://issues.apache.org/jira/browse/HIVE-14502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15423706#comment-15423706
 ] 

Prasanth Jayachandran commented on HIVE-14502:
----------------------------------------------

I have moved most of the tez tests to llap. Few things
1) hybrid grace hash join works only for tez and is disabled for llap. So I 
left the hybrid grace hash join tests to run under minitez
2) I compared the golden file outputs from tez with that of generated by llap. 
Most of them did not show any diff that affected the query results. I basically 
ran diff between tez and llap out files ignoring the lines that will show 
"llap" in explain output and most of them showed no differences.
3) There are 4 tests which showed some difference insert1.q, orc_merge12.q, 
unionDistinct_2.q, vector_join_part_col_char.q.
 
insert1.q is showing following diff related to posthook + lineage
{code}
< POSTHOOK: Lineage: insert1.key SIMPLE [(insert2)a.FieldSchema(name:key, 
type:int, comment:null), ]
---
> POSTHOOK: Lineage: insert1.key SIMPLE []
{code}

orc_merge12.q is showing hash diff.. This can happen only if results are 
different.
{code}
< -302946892512
---
> 42986028888
{code}

vector_join_part_col_char.q is showing padded spaces which is not shown in tez 
output.

unionDistinct_2.q is missing privileges info in output

{code}
< ) `tab`, tableType:VIRTUAL_VIEW, 
privileges:PrincipalPrivilegeSet(userPrivileges:{hive_test_user=[PrivilegeGrantInfo(privilege:INSERT,
 createTime:-1, grantor:hive_test_user, grantorType:USER, grantOption:true), 
PrivilegeGrantInfo(privilege:SELECT, createTime:-1, grantor:hive_test_user, 
grantorType:USER, grantOption:true), PrivilegeGrantInfo(privilege:UPDATE, 
createTime:-1, grantor:hive_test_user, grantorType:USER, grantOption:true), 
PrivilegeGrantInfo(privilege:DELETE, createTime:-1, grantor:hive_test_user, 
grantorType:USER, grantOption:true)]}, groupPrivileges:null, 
rolePrivileges:null))
---
> ) `tab`, tableType:VIRTUAL_VIEW)
{code}

For now I have left these tests under minitez itself. Will move them after 
initial run or in a follow up. 

> Convert MiniTez tests to MiniLlap tests
> ---------------------------------------
>
>                 Key: HIVE-14502
>                 URL: https://issues.apache.org/jira/browse/HIVE-14502
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Test
>    Affects Versions: 2.2.0
>            Reporter: Prasanth Jayachandran
>            Assignee: Prasanth Jayachandran
>         Attachments: HIVE-14502.1.patch
>
>
> Llap shares most of the codepath with tez. MiniLlapCliDriver is much faster 
> than MiniTezCliDriver because of threaded executors and caching. 
> MiniTezCliDriver tests takes around 3hr 15mins to run around 400 tests. To 
> cut down this test time significantly it makes sense to move over mive tez 
> tests to mini llap tests.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to