[ https://issues.apache.org/jira/browse/HIVE-14323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15395418#comment-15395418 ]
Steve Loughran commented on HIVE-14323: --------------------------------------- Having just reviewed the hive and hadoop code, we all have that same bad habit: treat a false return value as some kind of error. As Hadoop gets it wrong too, no need to feel bad > Reduce number of FS permissions and redundant FS operations > ----------------------------------------------------------- > > Key: HIVE-14323 > URL: https://issues.apache.org/jira/browse/HIVE-14323 > Project: Hive > Issue Type: Improvement > Reporter: Rajesh Balamohan > Assignee: Rajesh Balamohan > Priority: Minor > Attachments: HIVE-14323.1.patch, HIVE-14323.2.patch > > > Some examples are given below. > 1. When creating stage directory, FileUtils sets the directory permissions by > running a set of chgrp and chmod commands. In systems like S3, this would not > be relevant. > 2. In some cases, fs.delete() is followed by fs.exists(). In this case, it > might be redundant to check for exists() (lookup ops are expensive in systems > like S3). -- This message was sent by Atlassian JIRA (v6.3.4#6332)