[ https://issues.apache.org/jira/browse/HIVE-11943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394681#comment-15394681 ]
Vihang Karajgaonkar edited comment on HIVE-11943 at 7/26/16 10:31 PM: ---------------------------------------------------------------------- Hi [~Ferd] I am trying to understand the patch for this issue. In the patch the cli.sh is modified such that if USE_DEPRECATED_CLI is not set it is set to true but in cli.cmd file it is set to false {code} +# Set old CLI as the default client +if [ -n '$USE_DEPRECATED_CLI' ]; then + USE_DEPRECATED_CLI="true" +fi + {code} {code} + if [%USE_DEPRECATED_CLI%] == [] ( + set USE_DEPRECATED_CLI=false + ) + {code} Is that intentional? or it should be set to true in cli.cmd also? was (Author: vihangk1): Hi [~Ferd] I am trying to understand the patch for this issue. In the patch the cli.sh is modified such that if USE_DEPRECATED_CLI is not set it is set to true but in cli.cmd file it is set to true {code} +# Set old CLI as the default client +if [ -n '$USE_DEPRECATED_CLI' ]; then + USE_DEPRECATED_CLI="true" +fi + {code} {code} + if [%USE_DEPRECATED_CLI%] == [] ( + set USE_DEPRECATED_CLI=false + ) + {code} Is that intentional? or it should be set to true in cli.cmd also? > Set old CLI as the default Client when using hive script > -------------------------------------------------------- > > Key: HIVE-11943 > URL: https://issues.apache.org/jira/browse/HIVE-11943 > Project: Hive > Issue Type: Sub-task > Components: CLI > Affects Versions: beeline-cli-branch > Reporter: Ferdinand Xu > Assignee: Ferdinand Xu > Fix For: beeline-cli-branch > > Attachments: HIVE-11943.1-beeline-cli.patch > > > Since we have some concerns about deprecating the current CLI, we will set > the old CLI as default. Once we resolve the problems, we will set the new CLI > as default. -- This message was sent by Atlassian JIRA (v6.3.4#6332)