[
https://issues.apache.org/jira/browse/HIVE-14251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385164#comment-15385164
]
Mohit Sabharwal commented on HIVE-14251:
----------------------------------------
LGTM.
If i understand correctly, the only difference between isCommonTypeOf and
implicitConvertible is this line
{code}
// Allow implicit String to Double conversion
if (fromPg == PrimitiveGrouping.STRING_GROUP && to ==
PrimitiveCategory.DOUBLE) {
return true;
}
{code}
Wondering if it's easy to re-use implicitConvertible instead of duplicating the
code ? Maybe add a flag to the method
for String to Double conversion ?
> Union All of different types resolves to incorrect data
> -------------------------------------------------------
>
> Key: HIVE-14251
> URL: https://issues.apache.org/jira/browse/HIVE-14251
> Project: Hive
> Issue Type: Bug
> Components: Query Planning
> Affects Versions: 2.0.0
> Reporter: Aihua Xu
> Assignee: Aihua Xu
> Attachments: HIVE-14251.1.patch
>
>
> create table src(c1 date, c2 int, c3 double);
> insert into src values ('2016-01-01',5,1.25);
> select * from
> (select c1 from src union all
> select c2 from src union all
> select c3 from src) t;
> It will return NULL for the c1 values. Seems the common data type is resolved
> to the last c3 which is double.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
