[
https://issues.apache.org/jira/browse/HIVE-14169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384925#comment-15384925
]
Sahil Takiar commented on HIVE-14169:
-------------------------------------
Hey [~taoli-hwx]
* Yes, by default it is still false
* For non-table formats we came to the conclusion that there is no real benefit
to using BufferedRows. It only really makes sense if the table output format is
used. The reason is that if table output format is used along with
BufferedRows, then the BufferedRows can calculate the optimal sizing for each
row that it prints out. However, this isn't applicable for non-table formats.
This is why I made the change to stop honoring the value of incremental if a
non-table format is used.
Also, I am going to close this JIRA and mark it as a duplicate of HIVE-14170 -
since it doesn't make sense to commit these changes without HIVE-14170 along
with it.
> Honor --incremental flag only if TableOutputFormat is used
> ----------------------------------------------------------
>
> Key: HIVE-14169
> URL: https://issues.apache.org/jira/browse/HIVE-14169
> Project: Hive
> Issue Type: Sub-task
> Components: Beeline
> Reporter: Sahil Takiar
> Assignee: Sahil Takiar
> Attachments: HIVE-14169.1.patch
>
>
> * When Beeline prints out a {{ResultSet}} to stdout it uses the
> {{BeeLine.print}} method
> * This method takes the {{ResultSet}} from the completed query and uses a
> specified {{OutputFormat}} to print the rows (by default it uses
> {{TableOutputFormat}})
> * The {{print}} method also wraps the {{ResultSet}} into a {{Rows}} class
> (either a {{IncrementalRows}} or a {{BufferedRows}} class)
> The advantage of {{BufferedRows}} is that it can do a global calculation of
> the column width, however, this is only useful for {{TableOutputFormat}}. So
> there is no need to buffer all the rows if a different {{OutputFormat}} is
> used. This JIRA will change the behavior of the {{--incremental}} flag so
> that it is only honored if {{TableOutputFormat}} is used.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
