[
https://issues.apache.org/jira/browse/HIVE-14170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384884#comment-15384884
]
Sahil Takiar commented on HIVE-14170:
-------------------------------------
Hey [~taoli-hwx]!
Thanks for taking a look at this patch and welcome to Hive :) I'm pretty new to
the project also!
* Yes, this JIRA is a sub-task of HIVE-7224 which plans to set incremental mode
to be true by default. Once all the subtasks of HIVE-7224 are done I will make
the change.
* There is one advantage to using buffered mode, if TableOutputFormat is used
(it is used by default), then all row sizes will be normalized to the same
length (it's just an aesthetic thing, but some users may want it to stay as an
available option)
* I like your idea of making a sub-class of IncrementalRows, I will make that
change; I agree non-table formats don't need any normalization
* We could change BufferedRows, but it seems it would eventually just end up
being the same as IncrementalRows. It may be best just to focus on fixing
IncrementalRows, and leave BufferedRows as is.
> Beeline IncrementalRows should buffer rows and incrementally re-calculate
> width if TableOutputFormat is used
> ------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-14170
> URL: https://issues.apache.org/jira/browse/HIVE-14170
> Project: Hive
> Issue Type: Sub-task
> Components: Beeline
> Reporter: Sahil Takiar
> Assignee: Sahil Takiar
> Attachments: HIVE-14170.1.patch, HIVE-14170.2.patch
>
>
> If {{--incremental}} is specified in Beeline, rows are meant to be printed
> out immediately. However, if {{TableOutputFormat}} is used with this option
> the formatting can look really off.
> The reason is that {{IncrementalRows}} does not do a global calculation of
> the optimal width size for {{TableOutputFormat}} (it can't because it only
> sees one row at a time). The output of {{BufferedRows}} looks much better
> because it can do this global calculation.
> If {{--incremental}} is used, and {{TableOutputFormat}} is used, the width
> should be re-calculated every "x" rows ("x" can be configurable and by
> default it can be 1000).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
