[ 
https://issues.apache.org/jira/browse/HIVE-13997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15349952#comment-15349952
 ] 

Rui Li commented on HIVE-13997:
-------------------------------

V2 patch moved the delete logic to moveFileInDfs. If Hive.moveFile is intended 
to take care of replacing the files, I still prefer to leave the logic there. 
It might hurt performance, but correctness is more important. Anyway let's see 
how test goes.
To clear the dest dir, we need to delete all the sub dirs under it which don't 
contain the src dir. That's why we need recursive delete.

> Insert overwrite directory doesn't overwrite existing files
> -----------------------------------------------------------
>
>                 Key: HIVE-13997
>                 URL: https://issues.apache.org/jira/browse/HIVE-13997
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Rui Li
>            Assignee: Rui Li
>         Attachments: HIVE-13997.1.patch, HIVE-13997.2.patch
>
>
> Can be easily reproduced by running {{INSERT OVERWRITE DIRECTORY}} to the 
> same dir twice.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to