[ https://issues.apache.org/jira/browse/HIVE-13942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316049#comment-15316049 ]
Hive QA commented on HIVE-13942: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12808042/HIVE-13942.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 14 failed/errored test(s), 10222 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_acid_globallimit org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_acid_table_stats org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_constantPropWhen org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_insert_values_orig_table_use_metadata org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_list_bucket_dml_12 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_list_bucket_dml_13 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_ppd_udf_case org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_stats_list_bucket org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_subquery_multiinsert org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver_hbase_pushdown org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver_constprog_partitioner org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver_index_bitmap3 org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_acid_globallimit org.apache.hive.minikdc.TestHs2HooksWithMiniKdc.org.apache.hive.minikdc.TestHs2HooksWithMiniKdc {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/7/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/7/console Test logs: http://ec2-50-18-27-0.us-west-1.compute.amazonaws.com/logs/PreCommit-HIVE-MASTER-Build-7/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 14 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12808042 - PreCommit-HIVE-MASTER-Build > Correctness of CASE folding in the presence of NULL values > ---------------------------------------------------------- > > Key: HIVE-13942 > URL: https://issues.apache.org/jira/browse/HIVE-13942 > Project: Hive > Issue Type: Sub-task > Components: CBO > Affects Versions: 2.2.0, 2.1.1 > Reporter: Jesus Camacho Rodriguez > Assignee: Jesus Camacho Rodriguez > Attachments: HIVE-13942.patch > > > Introduced in HIVE-13068. > {{(case when key<'90' then 2 else 4 end) > 3}} should not fold to {{key >= > '90'}}, as these two expressions are not equivalent (consider _null_ values). > Instead, it should fold to {{not NVL((key < '90'),false)}}. > This is caused by 1) some methods still calling original _RexUtil.simplify_ > method where the bug was originally present, and 2) further improvements > needed in _HiveRexUtil.simplify_. -- This message was sent by Atlassian JIRA (v6.3.4#6332)