[ https://issues.apache.org/jira/browse/HIVE-11417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15277315#comment-15277315 ]
Prasanth Jayachandran commented on HIVE-11417: ---------------------------------------------- Left 2 minor comments in RB. Also had another comment about possible file descriptor leak in PR. The patch mostly looks like moving around code. The row-by-row shim and removal of next() looks good to me. +1, pending a clean test run > Create shims for the row by row read path that is backed by VectorizedRowBatch > ------------------------------------------------------------------------------ > > Key: HIVE-11417 > URL: https://issues.apache.org/jira/browse/HIVE-11417 > Project: Hive > Issue Type: Sub-task > Reporter: Owen O'Malley > Assignee: Owen O'Malley > Fix For: 2.1.0 > > Attachments: HIVE-11417.patch, HIVE-11417.patch, HIVE-11417.patch, > HIVE-11417.patch, HIVE-11417.patch, HIVE-11417.patch > > > I'd like to make the default path for reading and writing ORC files to be > vectorized. To ensure that Hive can still read row by row, we'll need shims > to support the old API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)