[ https://issues.apache.org/jira/browse/HIVE-13670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15272714#comment-15272714 ]
Gunther Hagleitner commented on HIVE-13670: ------------------------------------------- If you're introducing saved variables, I think you should have a full set of CRUD to deal with them. I think the current patch doesn't allow you to unset or list them. It's also strange to limit their use to this one place - the connect string. One way to introduce them would be to replace them with their value in any !<statement> before evaluation. You also don't have a naming scheme for the variables. And if they clash with a property you use that instead. Finally the way it's invoked is by a fallback in an error case (failed to connect using string, fallback to see if it's a variable). Why not invoke them with $<var> and enforce <letter><alphanum>* ? > Improve Beeline reconnect semantics > ----------------------------------- > > Key: HIVE-13670 > URL: https://issues.apache.org/jira/browse/HIVE-13670 > Project: Hive > Issue Type: Improvement > Affects Versions: 2.1.0 > Reporter: Sushanth Sowmyan > Assignee: Sushanth Sowmyan > Attachments: HIVE-13670.2.patch, HIVE-13670.patch > > > For most users of beeline, chances are that they will be using it with a > single HS2 instance most of the time. In this scenario, having them type out > a jdbc uri for HS2 every single time to !connect can get tiresome. Thus, we > should improve semantics so that if a user does a successful !connect, then > we must store the last-connected-to-url, so that if they do a !close, and > then a !reconnect, then !reconnect should attempt to connect to the last > successfully used url. > Also, if they then do a !save, then that last-successfully-used url must be > saved, so that in subsequent sessions, they can simply do !reconnect rather > than specifying a url for !connect. -- This message was sent by Atlassian JIRA (v6.3.4#6332)