[ https://issues.apache.org/jira/browse/HIVE-11793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15272719#comment-15272719 ]
Eugene Koifman commented on HIVE-11793: --------------------------------------- this doesn't address the case where "dbname" is not specified. The solution in getLocksWithFilterOptions() to figure out default db only fixes the test. Why not do "SessionState.get().getCurrentDatabase()" if dbname is not set in HiveMetaStoreClient.showLocks(...) Then it works for all invocations? I'd also suggest setting dbname=default in TxnHandler if dbname is not set. > SHOW LOCKS with DbTxnManager ignores filter options > --------------------------------------------------- > > Key: HIVE-11793 > URL: https://issues.apache.org/jira/browse/HIVE-11793 > Project: Hive > Issue Type: Improvement > Components: Transactions > Affects Versions: 1.0.0 > Reporter: Eugene Koifman > Assignee: Wei Zheng > Priority: Minor > Attachments: HIVE-11793.1.patch, HIVE-11793.2.patch, > HIVE-11793.3.patch, HIVE-11793.4.patch, HIVE-11793.5.patch > > > https://cwiki.apache.org/confluence/display/Hive/Locking and > https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-ShowLocks > list various options that can be used with SHOW LOCKS, e.g. <TABLE> > When ACID is enabled, all these options are ignored and a full list is > returned. > (also only ext lock id is shown, int lock id is not). > see DDLTask.showLocks() and TxnHandler.showLocks() > requires extending ShowLocksRequest which is a Thrift object -- This message was sent by Atlassian JIRA (v6.3.4#6332)