[ 
https://issues.apache.org/jira/browse/HIVE-13608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15265971#comment-15265971
 ] 

Ashutosh Chauhan commented on HIVE-13608:
-----------------------------------------

Instead of re-wrapping exception in TException what needs to be done here is to 
not retry if there is a non-recoverable error like 
{{java.sql.SQLIntegrityConstraintViolationException}} For that you need to 
update regular expression which tries to determine whether its recoverable or 
not in {{if (e.getMessage().matches("(?s).*(IO|TTransport)Exception.*"))}} and 
throw straight away.

> We should provide better error message while constraints with duplicate names 
> are created
> -----------------------------------------------------------------------------------------
>
>                 Key: HIVE-13608
>                 URL: https://issues.apache.org/jira/browse/HIVE-13608
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Hari Sankar Sivarama Subramaniyan
>            Assignee: Hari Sankar Sivarama Subramaniyan
>         Attachments: HIVE-13608.1.patch
>
>
> {code}
> PREHOOK: query: create table t1(x int, constraint pk1 primary key (x) disable 
> novalidate)
> PREHOOK: type: CREATETABLE
> PREHOOK: Output: database:default
> PREHOOK: Output: default@t1
> POSTHOOK: query: create table t1(x int, constraint pk1 primary key (x) 
> disable novalidate)
> POSTHOOK: type: CREATETABLE
> POSTHOOK: Output: database:default
> POSTHOOK: Output: default@t1
> PREHOOK: query: create table t2(x int, constraint pk1 primary key (x) disable 
> novalidate)
> PREHOOK: type: CREATETABLE
> PREHOOK: Output: database:default
> PREHOOK: Output: default@t2
> FAILED: Execution Error, return code 1 from 
> org.apache.hadoop.hive.ql.exec.DDLTask. MetaException(message:For direct 
> MetaStore DB connections, we don't support retries at the client level.)
> {code}
> In the above case, it seems like useful error message is lost. It looks like 
> a  generic problem with metastore server/client exception handling and 
> message propagation. Seems like exception parsing logic of 
> RetryingMetaStoreClient::invoke() needs to be updated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to