[
https://issues.apache.org/jira/browse/HIVE-13643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262734#comment-15262734
]
Sergey Shelukhin commented on HIVE-13643:
-----------------------------------------
Nit: is it possible to capitalize LLAP in log lines?
{noformat}
if (StringUtils.isEmpty(appName)) {
+ appName = HiveConf.getVar(conf,
HiveConf.ConfVars.LLAP_DAEMON_SERVICE_HOSTS);
+ if (appName.startsWith("@") && appName.length() > 1) {
+ appName = appName.substring(1);
+ }
+ }
+ if (StringUtils.isEmpty(appName) || (appName.startsWith("@") ||
appName.length() == 1)) {
+ String message = "Invalid app name. This must be setup via config or
passed in as a parameter";
+ LOG.info(message);
+ return ExitCode.INCORRECT_USAGE.getInt();
+ }
{noformat}
Would an app name being a list of hosts with dots, commas and stuff actually
work? And make sense?
Also why cannot the length be 1
> Various enhancements / fixes to llap cli tools
> ----------------------------------------------
>
> Key: HIVE-13643
> URL: https://issues.apache.org/jira/browse/HIVE-13643
> Project: Hive
> Issue Type: Improvement
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: HIVE-13643.01.patch
>
>
> - BUG - llapstatus does not always produce output (PrintWriter.close)
> - llapstatus should parse hiveconf
> - package llap-cli-log4j2.template
> - Log at the start and end of the script to include parameters
> - Generate logs to a file different from hive.log
> - hive --service llap --name does not propagate the name to the daemons
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
