[ 
https://issues.apache.org/jira/browse/HIVE-11424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207964#comment-15207964
 ] 

Jesus Camacho Rodriguez commented on HIVE-11424:
------------------------------------------------

[~ashutoshc], nevermind what I said before...

The differences that I was seeing in pointlookup3.q were not due to that... I 
continued exploring and the reason is that PointLookupOptimizer in Hive 
transforms only OR-AND clauses that are at the top level of the Filter 
predicate. However, the rule I implemented in Calcite will transform them even 
if they are not at the top level of the predicate. Thus, Calcite rule covers 
more cases.

I believe we still need to migrate partition condition remover to Calcite to 
fold expressions tighter, but we are not regressing wrt to current status by 
migrating the rule to Calcite, thus patch could go in without the new flag that 
I mentioned above.

I have uploaded a new patch without the flag.

> Rule to transform OR clauses into IN clauses in CBO
> ---------------------------------------------------
>
>                 Key: HIVE-11424
>                 URL: https://issues.apache.org/jira/browse/HIVE-11424
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Jesus Camacho Rodriguez
>         Attachments: HIVE-11424.01.patch, HIVE-11424.01.patch, 
> HIVE-11424.03.patch, HIVE-11424.03.patch, HIVE-11424.04.patch, 
> HIVE-11424.05.patch, HIVE-11424.2.patch, HIVE-11424.patch
>
>
> We create a rule that will transform OR clauses into IN clauses (when 
> possible).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to