[ 
https://issues.apache.org/jira/browse/HIVE-13283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15204929#comment-15204929
 ] 

Vikram Dixit K commented on HIVE-13283:
---------------------------------------

Minor comment:

{code}
+    String defaultVal = null;
+    String val = HiveConf.getVar(conf, ConfVars.LLAP_IO_ENABLED, defaultVal);
+    boolean isEnabled = (val != null) ? Boolean.parseBoolean(val) : 
LlapProxy.isDaemon();
{code}

You could just use the HiveConf.getBoolVar() method with a default 
LlapProxy.isDaemon() to get the same effect.

Just for clarification, user could set this configuration to false and the 
daemon would not use the IOElevator? Is that the right way to look at this 
configuration or did you want the daemon to always use IOElevator?

> LLAP: make sure IO elevator is enabled by default in the daemons
> ----------------------------------------------------------------
>
>                 Key: HIVE-13283
>                 URL: https://issues.apache.org/jira/browse/HIVE-13283
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HIVE-13283.01.patch, HIVE-13283.02.patch, 
> HIVE-13283.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to