[ https://issues.apache.org/jira/browse/HIVE-13216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186589#comment-15186589 ]
Hive QA commented on HIVE-13216: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12791860/HIVE-13216.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 8 failed/errored test(s), 9772 tests executed *Failed tests:* {noformat} TestMiniTezCliDriver-vector_distinct_2.q-vector_interval_2.q-load_dyn_part2.q-and-12-more - did not produce a TEST-*.xml file TestSparkCliDriver-groupby3_map.q-sample2.q-auto_join14.q-and-12-more - did not produce a TEST-*.xml file TestSparkCliDriver-groupby_map_ppr_multi_distinct.q-table_access_keys_stats.q-groupby4_noskew.q-and-12-more - did not produce a TEST-*.xml file TestSparkCliDriver-join_rc.q-insert1.q-vectorized_rcfile_columnar.q-and-12-more - did not produce a TEST-*.xml file TestSparkCliDriver-ppd_join4.q-join9.q-ppd_join3.q-and-12-more - did not produce a TEST-*.xml file TestSparkCliDriver-timestamp_lazy.q-bucketsortoptimize_insert_4.q-date_udf.q-and-12-more - did not produce a TEST-*.xml file org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_uri_import org.apache.hive.jdbc.TestSSL.testSSLVersion {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/7199/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/7199/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-7199/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 8 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12791860 - PreCommit-HIVE-TRUNK-Build > ORC Reader will leave file open until GC when opening a malformed ORC file > -------------------------------------------------------------------------- > > Key: HIVE-13216 > URL: https://issues.apache.org/jira/browse/HIVE-13216 > Project: Hive > Issue Type: Bug > Components: File Formats, ORC > Affects Versions: 1.2.0, 1.2.1, 2.0.0 > Reporter: Yuxing Yao > Assignee: Sergey Shelukhin > Priority: Minor > Attachments: HIVE-13216.patch > > > In ORC extractMetaInfoFromFooter method of ReaderImpl.java: > A new input stream is open without try-catch-finally to enforce closing. > Once the footer parse has some exception, the stream close will miss. > Until GC happen to close the stream. > private static FileMetaInfo extractMetaInfoFromFooter(FileSystem fs, > Path path, > long maxFileLength > ) throws IOException { > FSDataInputStream file = fs.open(path); > ... > file.close(); > return new FileMetaInfo( > ps.getCompression().toString(), > (int) ps.getCompressionBlockSize(), > (int) ps.getMetadataLength(), > buffer, > ps.getVersionList(), > writerVersion > ); > } -- This message was sent by Atlassian JIRA (v6.3.4#6332)