[ 
https://issues.apache.org/jira/browse/HIVE-12777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15104171#comment-15104171
 ] 

Xuefu Zhang commented on HIVE-12777:
------------------------------------

Sorry but I still don't understand what functionality we are adding here. We 
should have clear description of the problem we are trying to solve, the new 
functionality we are adding, and the approach we are taking, For bigger feature 
additions, we might even need a functional and design doc.

The doc or JIRA description is supposed to help code review, but not the other 
way around. Here it seems I have to understand the code in order to understand 
the feature.

> Add capability to restore session
> ---------------------------------
>
>                 Key: HIVE-12777
>                 URL: https://issues.apache.org/jira/browse/HIVE-12777
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Rajat Khandelwal
>            Assignee: Rajat Khandelwal
>         Attachments: HIVE-12777.04.patch, HIVE-12777.08.patch, 
> HIVE-12777.09.patch, HIVE-12777.11.patch, HIVE-12777.12.patch, 
> HIVE-12777.13.patch
>
>
> Extensions using Hive session handles should be able to restore the hive 
> session from the handle. 
> Apache Lens depends on a fork of hive and that fork has such a capability. 
> Relevant commit: 
> https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to