[
https://issues.apache.org/jira/browse/HIVE-29470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18059870#comment-18059870
]
László Bodor edited comment on HIVE-29470 at 2/20/26 9:18 AM:
--------------------------------------------------------------
all the tests passed:
https://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-6326/5/pipeline
for my commit:
https://github.com/abstractdog/hive/commit/06ce23fb04bb2e862d0cf511f5ac214ce1e6bee9
this is really bad: I believe by commenting these lines out, the whole
hive-exec jar localization would not take place (unless it's hacked from aux
jars, maybe, not sure), so this must be covered with tests, I can imagine 2 ways
1. easy: simple unit test to ensure commonLocalResources after opening a Tez
session <- crucial short-term
2. harder: implement an integration testing mechanism (inspired by current
qtest drivers maybe), that can utilize a real mini yarn cluster, that relies on
the localized hive-exec jar (and figure out first how the current
TestMiniTezCliDriver works and all tests pass on that driver with the above
hack patch in place) <-- nice-to-have long-term
was (Author: abstractdog):
all the tests passed:
https://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-6326/5/pipeline
for my commit:
https://github.com/abstractdog/hive/commit/06ce23fb04bb2e862d0cf511f5ac214ce1e6bee9
this is really bad: I believe by commenting these lines out, the whole
hive-exec jar localization would not take place (unless it's hacked from aux
jars), so this must be covered with tests, I can imagine 2 ways
1. easy: simple unit test to ensure commonLocalResources after opening a Tez
session <- crucial short-term
2. harder: implement an integration testing mechanism (inspired by current
qtest drivers maybe), that can utilize a real mini yarn cluster, that relies on
the localized hive-exec jar (and figure out first how the current
TestMiniTezCliDriver works and all tests pass on that driver with the above
hack patch in place) <-- nice-to-have long-term
> Double-check if precommit covers real Tez on Yarn jar localization
> ------------------------------------------------------------------
>
> Key: HIVE-29470
> URL: https://issues.apache.org/jira/browse/HIVE-29470
> Project: Hive
> Issue Type: Improvement
> Reporter: László Bodor
> Assignee: László Bodor
> Priority: Major
> Labels: pull-request-available
>
> Recently, in a downstream precommit I made a fatal failure in TezSessionState
> related to hive-exec jar localization, and the normal precommit tests didn't
> cover it. Need to double-check that's the case upstream too, so I'll create a
> dummy PR that does a similar mistake.
> See this example commit that disables jar localization:
> https://github.com/abstractdog/hive/commit/06ce23fb04bb2e862d0cf511f5ac214ce1e6bee9
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
