Stamatis Zampetakis created HIVE-29025:
------------------------------------------
Summary: Remove unused RelFieldTrimmer#trimFields methods for Jdbc
operators
Key: HIVE-29025
URL: https://issues.apache.org/jira/browse/HIVE-29025
Project: Hive
Issue Type: Task
Components: Query Planning
Reporter: Stamatis Zampetakis
Assignee: Stamatis Zampetakis
In the current master (commit 42f8e0a7499c5158b3df9ecada97e734bd509ec6) it is
impossible to call the
[RelFieldTrimmer|https://github.com/apache/hive/blob/42f8e0a7499c5158b3df9ecada97e734bd509ec6/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/RelFieldTrimmer.java]
class with Jdbc operators other than HiveJdbcConverter and JdbcHiveTableScan.
The [JDBC pushdown
rules|https://github.com/apache/hive/blob/42f8e0a7499c5158b3df9ecada97e734bd509ec6/ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java#L2397]
that introduce JdbcFilter,JdbcJoin, JdbcProject, etc., are called after
applying field trimming so the respective methods in RelFieldTrimmer will never
be called by existing code.
I propose to remove the unused methods to reduce maintenance overhead and bring
the class closer to its counterpart in the [Calcite
repo|https://github.com/apache/calcite/blob/597b1fd54fe5b8586525aed2bc4518ca54a25523/core/src/main/java/org/apache/calcite/sql2rel/RelFieldTrimmer.java].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
