[ 
https://issues.apache.org/jira/browse/HIVE-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15014838#comment-15014838
 ] 

Alan Gates commented on HIVE-12367:
-----------------------------------

The test failures definitely look relevant and need to be fixed or regenerated. 
 

The patch looks fine.  A comment on why you are selecting DDL_NO_LOCK in the 
lock function would be helpful, since it's confusing.  Also, analyzeLockTable 
and analyzeUnlockTable suffer from the same problem.  I don't know if you want 
to fix those as well.

> Lock/unlock database should add current database to inputs and outputs of 
> authz hook
> ------------------------------------------------------------------------------------
>
>                 Key: HIVE-12367
>                 URL: https://issues.apache.org/jira/browse/HIVE-12367
>             Project: Hive
>          Issue Type: Bug
>          Components: Authorization
>    Affects Versions: 1.2.1
>            Reporter: Dapeng Sun
>            Assignee: Dapeng Sun
>         Attachments: HIVE-12367.001.patch, HIVE-12367.002.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to