[
https://issues.apache.org/jira/browse/HIVE-28499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17879111#comment-17879111
]
Butao Zhang edited comment on HIVE-28499 at 9/4/24 6:26 AM:
------------------------------------------------------------
I want to leave this ticket open to attract more dev attention about the code
style configuration.
IMO. we have lots of diiferent code styles in code base, and it is hard for new
developers to do code format. Even though we have a specific checkstyle in the
module hive-iceberg, we may also encounter issues like this ticket.
I think we need to think about a way to improve this, like using a unified
checkstyle, or using spotless to clean up the all code base. I know this will
change many code files, which may have a bad effect for the following code
review, but long pain rather short pain, i think we can try to do this!
was (Author: zhangbutao):
I want to leave this ticket open to attract more dev attention about the code
style configuration.
IMO. we have lots of diiferent code styles in code base, and it is hard for new
developers to do code format. Even though we have a specific checkstyle in the
module hive-iceberg, we may also encounter issues like this ticket.
I think we need to think about a way to improve this, like using a unified
checkstyle, or using spotless to clean up the all code base. I know this will
change many code files, which may have a bad effect for the following code
review, but long pain than short-term pain, i think we can try to do this!
> Intellij Idea2024 can't import iceberg&hive checkstyle files
> ------------------------------------------------------------
>
> Key: HIVE-28499
> URL: https://issues.apache.org/jira/browse/HIVE-28499
> Project: Hive
> Issue Type: Improvement
> Reporter: Butao Zhang
> Priority: Major
> Attachments: idea2024-checkstyle-8.28.jpg,
> idea2024-checkstyle-tool-error.jpg, idea2024-import-iceberg-checkstyle_1.jpg,
> idea2024-import-iceberg-checkstyle_2.jpg,
> idea2024-import-iceberg-checkstyle_error_3.jpg,
> idea2024-with-checkstyle-plugin-5.86.0.jpg, install_checkstyle_plugin.jpg
>
>
> I upgraded my Intellij from 2022 to 2024 version, and i found that i can't
> import iceberg&hive checkstyle files.
> {code:java}
> IntelliJ IDEA 2024.2.1 (Ultimate Edition)
> Build #IU-242.21829.142, built on August 28, 2024{code}
> Here are some screen shot & steps of my Intellij 2024:
> 1. Install CheckStyle-IDEA plugin
> !install_checkstyle_plugin.jpg!
> 2. import hive-iceberg checkstyle files using Code Style setting
> !idea2024-import-iceberg-checkstyle_1.jpg!
>
> import this file
> [https://github.com/apache/hive/blob/master/iceberg/checkstyle/checkstyle.xml]
> !idea2024-import-iceberg-checkstyle_2.jpg!
>
> 3. import checkstyle failed
> !idea2024-import-iceberg-checkstyle_error_3.jpg!
>
> 4. Checkstyle tool also failed
> {code:java}
> com.puppycrawl.tools.checkstyle.api.CheckstyleException:
> SuppressWithNearbyCommentFilter is not allowed as a child in Checker
> at com.puppycrawl.tools.checkstyle.Checker.setupChild(Checker.java:501)
> at
> com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure(AutomaticBean.java:201)
> at
> org.infernus.idea.checkstyle.service.cmd.OpCreateChecker.execute(OpCreateChecker.java:61)
> at
> org.infernus.idea.checkstyle.service.cmd.OpCreateChecker.execute(OpCreateChecker.java:26)
> at
> org.infernus.idea.checkstyle.service.CheckstyleActionsImpl.executeCommand(CheckstyleActionsImpl.java:116)
> at
> org.infernus.idea.checkstyle.service.CheckstyleActionsImpl.createChecker(CheckstyleActionsImpl.java:60)
> at
> org.infernus.idea.checkstyle.service.CheckstyleActionsImpl.createChecker(CheckstyleActionsImpl.java:51)
> at
> org.infernus.idea.checkstyle.checker.CheckerFactoryWorker.run(CheckerFactoryWorker.java:42)
> {code}
> !idea2024-checkstyle-tool-error.jpg!
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
