[
https://issues.apache.org/jira/browse/HIVE-11358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15010257#comment-15010257
]
Lefty Leverenz commented on HIVE-11358:
---------------------------------------
General questions:
1. Why don't the parameters that take a time value use a TimeValidator? For
examples, see hive.spark.client.future.timeout in the patch (seconds) and
hive.stats.retries.wait in HiveConf.java (milliseconds).
2. Why is milliseconds "ms" in some parameter names and "millis" in others?
3. Why do several parameter names use hyphens where normally there would be
dots?
Hyphens in parameter names:
* hive.llap.daemon.shuffle.dir-watcher.enabled
* hive.llap.daemon.am.liveness.heartbeat.interval-ms
* hive.llap.am.liveness.connection.timeout-millis
* hive.llap.am.liveness.connection.sleep-between-retries-millis
* hive.llap.file.cleanup.delay-seconds
* hive.llap.task.communicator.connection.timeout-millis
* hive.llap.task.communicator.connection.sleep-between-retries-millis
Also hive.llap.task.scheduler.node.re-enable.min.timeout.ms &
hive.llap.task.scheduler.node.re-enable.max.timeout.ms but those are genuine
hyphens.
> LLAP: move LlapConfiguration into HiveConf and document the settings
> --------------------------------------------------------------------
>
> Key: HIVE-11358
> URL: https://issues.apache.org/jira/browse/HIVE-11358
> Project: Hive
> Issue Type: Sub-task
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HIVE-11358.01.patch, HIVE-11358.patch
>
>
> Hive uses HiveConf for configuration. LlapConfiguration should be replaced
> with parameters in HiveConf
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
