[
https://issues.apache.org/jira/browse/HIVE-27944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
yongzhi.shao updated HIVE-27944:
--------------------------------
Description:
We found that org.apache.hadoop.hive.ql.plan.PartitionDesc.equals() may
deadlock in a multithreaded environment.
Here's the deadlock information we've gathered:
{code:java}
"DAG44-Input-4-16" Id=161 BLOCKED on
org.apache.hadoop.hive.common.CopyOnFirstWriteProperties@44196d35 owned by
"DAG44-Input-4-15" Id=160
at
org.apache.hadoop.hive.common.CopyOnFirstWriteProperties.size(CopyOnFirstWriteProperties.java:315)
- blocked on
org.apache.hadoop.hive.common.CopyOnFirstWriteProperties@44196d35
at java.util.Hashtable.equals(Hashtable.java:801)
- locked java.util.Properties@77a541be <---- but blocks 3 other threads!
at
org.apache.hadoop.hive.common.CopyOnFirstWriteProperties.equals(CopyOnFirstWriteProperties.java:213)
- locked org.apache.hadoop.hive.common.CopyOnFirstWriteProperties@2d973aa3
at
org.apache.hadoop.hive.ql.plan.PartitionDesc.equals(PartitionDesc.java:327)
at java.util.AbstractMap.equals(AbstractMap.java:495)
at java.util.concurrent.ConcurrentHashMap.get(ConcurrentHashMap.java:940)
at
org.apache.hadoop.hive.ql.io.HiveFileFormatUtils.getFromPathRecursively(HiveFileFormatUtils.java:374)
at
org.apache.hadoop.hive.ql.io.HiveFileFormatUtils.getFromPathRecursively(HiveFileFormatUtils.java:359)
at
org.apache.hadoop.hive.ql.io.HiveFileFormatUtils.getFromPathRecursively(HiveFileFormatUtils.java:354)
at
org.apache.hadoop.hive.ql.exec.tez.SplitGrouper.schemaEvolved(SplitGrouper.java:278)
at
org.apache.hadoop.hive.ql.exec.tez.SplitGrouper.generateGroupedSplits(SplitGrouper.java:183)
at
org.apache.hadoop.hive.ql.exec.tez.SplitGrouper.generateGroupedSplits(SplitGrouper.java:160)
at
org.apache.hadoop.hive.ql.exec.tez.HiveSplitGenerator.initialize(HiveSplitGenerator.java:287)
{code}
Since the Properties object inherits the HashTable interface, all the methods
of the HashTable interface are synchronised.
In a multi-threaded environment, a deadlock will occur when propA.equals(propB)
and propB.equals(propA) occur at the same time.
我这里有一个修复方案,在我们调用CopyOnFirstWriteProperties.equals()时,我们可以在这个方法内进行一次对象复制.用复制后的对象进行比对.如果这个方案没有什么问题,我将提交PR.
was:
We found that org.apache.hadoop.hive.ql.plan.PartitionDesc.equals() may
deadlock in a multithreaded environment.
Here's the deadlock information we've gathered:
{code:java}
"DAG44-Input-4-16" Id=161 BLOCKED on
org.apache.hadoop.hive.common.CopyOnFirstWriteProperties@44196d35 owned by
"DAG44-Input-4-15" Id=160
at
org.apache.hadoop.hive.common.CopyOnFirstWriteProperties.size(CopyOnFirstWriteProperties.java:315)
- blocked on
org.apache.hadoop.hive.common.CopyOnFirstWriteProperties@44196d35
at java.util.Hashtable.equals(Hashtable.java:801)
- locked java.util.Properties@77a541be <---- but blocks 3 other threads!
at
org.apache.hadoop.hive.common.CopyOnFirstWriteProperties.equals(CopyOnFirstWriteProperties.java:213)
- locked org.apache.hadoop.hive.common.CopyOnFirstWriteProperties@2d973aa3
at
org.apache.hadoop.hive.ql.plan.PartitionDesc.equals(PartitionDesc.java:327)
at java.util.AbstractMap.equals(AbstractMap.java:495)
at java.util.concurrent.ConcurrentHashMap.get(ConcurrentHashMap.java:940)
at
org.apache.hadoop.hive.ql.io.HiveFileFormatUtils.getFromPathRecursively(HiveFileFormatUtils.java:374)
at
org.apache.hadoop.hive.ql.io.HiveFileFormatUtils.getFromPathRecursively(HiveFileFormatUtils.java:359)
at
org.apache.hadoop.hive.ql.io.HiveFileFormatUtils.getFromPathRecursively(HiveFileFormatUtils.java:354)
at
org.apache.hadoop.hive.ql.exec.tez.SplitGrouper.schemaEvolved(SplitGrouper.java:278)
at
org.apache.hadoop.hive.ql.exec.tez.SplitGrouper.generateGroupedSplits(SplitGrouper.java:183)
at
org.apache.hadoop.hive.ql.exec.tez.SplitGrouper.generateGroupedSplits(SplitGrouper.java:160)
at
org.apache.hadoop.hive.ql.exec.tez.HiveSplitGenerator.initialize(HiveSplitGenerator.java:287)
{code}
Since the Properties object inherits the HashTable interface, all the methods
of the HashTable interface are synchronised.
In a multi-threaded environment, a deadlock will occur when propA.equals(propB)
and propB.equals(propA) occur at the same time.
> When HIVE-LLAP reads the ICEBERG table, a deadlock may occur.
> -------------------------------------------------------------
>
> Key: HIVE-27944
> URL: https://issues.apache.org/jira/browse/HIVE-27944
> Project: Hive
> Issue Type: Bug
> Reporter: yongzhi.shao
> Priority: Major
>
> We found that org.apache.hadoop.hive.ql.plan.PartitionDesc.equals() may
> deadlock in a multithreaded environment.
> Here's the deadlock information we've gathered:
> {code:java}
> "DAG44-Input-4-16" Id=161 BLOCKED on
> org.apache.hadoop.hive.common.CopyOnFirstWriteProperties@44196d35 owned by
> "DAG44-Input-4-15" Id=160
> at
> org.apache.hadoop.hive.common.CopyOnFirstWriteProperties.size(CopyOnFirstWriteProperties.java:315)
> - blocked on
> org.apache.hadoop.hive.common.CopyOnFirstWriteProperties@44196d35
> at java.util.Hashtable.equals(Hashtable.java:801)
> - locked java.util.Properties@77a541be <---- but blocks 3 other threads!
> at
> org.apache.hadoop.hive.common.CopyOnFirstWriteProperties.equals(CopyOnFirstWriteProperties.java:213)
> - locked
> org.apache.hadoop.hive.common.CopyOnFirstWriteProperties@2d973aa3
> at
> org.apache.hadoop.hive.ql.plan.PartitionDesc.equals(PartitionDesc.java:327)
> at java.util.AbstractMap.equals(AbstractMap.java:495)
> at java.util.concurrent.ConcurrentHashMap.get(ConcurrentHashMap.java:940)
> at
> org.apache.hadoop.hive.ql.io.HiveFileFormatUtils.getFromPathRecursively(HiveFileFormatUtils.java:374)
> at
> org.apache.hadoop.hive.ql.io.HiveFileFormatUtils.getFromPathRecursively(HiveFileFormatUtils.java:359)
> at
> org.apache.hadoop.hive.ql.io.HiveFileFormatUtils.getFromPathRecursively(HiveFileFormatUtils.java:354)
> at
> org.apache.hadoop.hive.ql.exec.tez.SplitGrouper.schemaEvolved(SplitGrouper.java:278)
> at
> org.apache.hadoop.hive.ql.exec.tez.SplitGrouper.generateGroupedSplits(SplitGrouper.java:183)
> at
> org.apache.hadoop.hive.ql.exec.tez.SplitGrouper.generateGroupedSplits(SplitGrouper.java:160)
> at
> org.apache.hadoop.hive.ql.exec.tez.HiveSplitGenerator.initialize(HiveSplitGenerator.java:287)
> {code}
> Since the Properties object inherits the HashTable interface, all the methods
> of the HashTable interface are synchronised.
> In a multi-threaded environment, a deadlock will occur when
> propA.equals(propB) and propB.equals(propA) occur at the same time.
>
> 我这里有一个修复方案,在我们调用CopyOnFirstWriteProperties.equals()时,我们可以在这个方法内进行一次对象复制.用复制后的对象进行比对.如果这个方案没有什么问题,我将提交PR.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
