[
https://issues.apache.org/jira/browse/HIVE-27382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17727474#comment-17727474
]
Stamatis Zampetakis commented on HIVE-27382:
--------------------------------------------
It makes sense to include in the Hive repo whatever we can but I guess we
should evaluate every case individually.
zabetak/postgres-tpcds-metastore:1.3 comes from here
https://github.com/zabetak/hive-postgres-metastore. The repo/image currently
holds a quite big database dump (~145MB compressed). I don't think we want the
dumb to become a part of the official Hive repo. I suppose we can bring in the
dockerfile but we should probably keep the data apart and download them during
the build. The dockerfile will become slightly more complex but seems doable.
Apart from points 1 to 3 mentioned in the description we probably need another
one:
4. Add CI action/step to build and publish the image(s) when needed
> RDMBS docker images: use official images or contribute Dockerfile to hive repo
> ------------------------------------------------------------------------------
>
> Key: HIVE-27382
> URL: https://issues.apache.org/jira/browse/HIVE-27382
> Project: Hive
> Issue Type: Improvement
> Reporter: László Bodor
> Priority: Major
>
> This is a technical debt to be solved, we use images like:
> {code}
> grep -iRH "getDockerImageName" -A 1
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/rules/PostgresTPCDS.java:
> public String getDockerImageName() {
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/rules/PostgresTPCDS.java-
> return "zabetak/postgres-tpcds-metastore:1.3";
> --
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/rules/Oracle.java:
> public String getDockerImageName() {
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/rules/Oracle.java-
> return "abstractdog/oracle-xe:18.4.0-slim";
> {code}
> oops, abstractdog is mine, anyway, so for instance, "-slim" image is used for
> a reason, and if there is no official slim image, it's fine to use this one
> but needs to be contributed to hive, like:
> 1. Dockerfile
> 2. build instructions
> 3. image to hive related docker registry
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
