[
https://issues.apache.org/jira/browse/HIVE-27331?focusedWorklogId=861482&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861482
]
ASF GitHub Bot logged work on HIVE-27331:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/May/23 09:53
Start Date: 11/May/23 09:53
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #4312:
URL: https://github.com/apache/hive/pull/4312#discussion_r1190926687
##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/HiveCustomStorageHandlerUtils.java:
##########
@@ -71,4 +73,26 @@ public static void setWriteOperation(Configuration conf,
String tableName, Conte
conf.set(WRITE_OPERATION_CONFIG_PREFIX + tableName, operation.name());
}
+
+ public static boolean isWriteOperation(Configuration conf, String
tableName) {
+ if (conf == null || tableName == null) {
+ return false;
+ }
+ String operation = conf.get(FILESCAN_WRITE_OPERATION_CONFIG_PREFIX +
getTableName(tableName));
+ return Context.Operation.DELETE.name().equalsIgnoreCase(operation) ||
+ Context.Operation.UPDATE.name().equalsIgnoreCase(operation);
+ }
+
+ public static void setFileScanOperationType(Configuration conf, String
tableName, Context.Operation operation) {
+ if (conf == null || tableName == null) {
+ return;
+ }
+ conf.set(
+ FILESCAN_WRITE_OPERATION_CONFIG_PREFIX + getTableName(tableName),
+ operation.name());
+ }
+
+ private static String getTableName(String tableName) {
Review Comment:
why do we need this? see how we pass it to
`HiveIcebergInputFormat.getVectorizationConfName(tableName)` in orcRecordReader
Issue Time Tracking
-------------------
Worklog Id: (was: 861482)
Time Spent: 0.5h (was: 20m)
> Iceberg: Rows are not deleted from table when execution mode is vectorized
> llap
> -------------------------------------------------------------------------------
>
> Key: HIVE-27331
> URL: https://issues.apache.org/jira/browse/HIVE-27331
> Project: Hive
> Issue Type: Bug
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Rows aren't getting deleted in case the iceberg table is of ORC format and
> using vectorisation & llap
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
