[
https://issues.apache.org/jira/browse/HIVE-27243?focusedWorklogId=861134&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861134
]
ASF GitHub Bot logged work on HIVE-27243:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/May/23 07:54
Start Date: 09/May/23 07:54
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #4289:
URL: https://github.com/apache/hive/pull/4289#discussion_r1188268871
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -330,6 +333,15 @@ public boolean canProvideBasicStatistics() {
return true;
}
+ @Override
+ public StorageFormatDescriptor
supportsLoadData(org.apache.hadoop.hive.metastore.api.Table tbl) {
+ if (tbl.getParameters() != null) {
+ String format = tbl.getParameters().get("write.format.default");
+ return StorageFormat.getStorageFormatFactory().get(format == null ?
IOConstants.PARQUET : format);
Review Comment:
could we refactor to `StorageFormat.getDescriptor(format)` ?
Issue Time Tracking
-------------------
Worklog Id: (was: 861134)
Time Spent: 1h 20m (was: 1h 10m)
> Iceberg: Implement Load data via temp table
> -------------------------------------------
>
> Key: HIVE-27243
> URL: https://issues.apache.org/jira/browse/HIVE-27243
> Project: Hive
> Issue Type: Sub-task
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Do a load data for iceberg via ingesting it to a temp table and then Insert
> into/overwrite. (Impala Approach)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
