[ 
https://issues.apache.org/jira/browse/HIVE-27304?focusedWorklogId=859806&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-859806
 ]

ASF GitHub Bot logged work on HIVE-27304:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/Apr/23 22:29
            Start Date: 29/Apr/23 22:29
    Worklog Time Spent: 10m 
      Work Description: aturoczy commented on code in PR #4276:
URL: https://github.com/apache/hive/pull/4276#discussion_r1181135903


##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/command/CommandAuthorizerV2.java:
##########
@@ -201,8 +201,7 @@ private static void addHivePrivObject(Entity privObject, 
Map<String, List<String
           HiveConf.ConfVars.HIVE_AUTHORIZATION_TABLES_ON_STORAGEHANDLERS)) {
         //TODO: add hive privilege object for storage based handlers for 
create and alter table commands.
         if (hiveOpType == HiveOperationType.CREATETABLE ||
-                hiveOpType == HiveOperationType.ALTERTABLE_PROPERTIES ||
-                hiveOpType == HiveOperationType.CREATETABLE_AS_SELECT) {

Review Comment:
   I don't get it, why a CTAS would not need at least a read permission? It is 
a bit odd change. Maybe I don't have context, but it would be great if other 
would check this request. cc: @kasakrisz @ayushtkn @deniskuzZ 





Issue Time Tracking
-------------------

    Worklog Id:     (was: 859806)
    Time Spent: 0.5h  (was: 20m)

> Exclude CTAS condition while forming storage handler url permissions in HS2 
> authorizer.
> ---------------------------------------------------------------------------------------
>
>                 Key: HIVE-27304
>                 URL: https://issues.apache.org/jira/browse/HIVE-27304
>             Project: Hive
>          Issue Type: Bug
>          Components: Hive
>            Reporter: Sai Hemanth Gantasala
>            Assignee: Sai Hemanth Gantasala
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> CTAS queries with storage handler table as source table doesn't require read 
> permissions on storage URL for the target table



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to