[ 
https://issues.apache.org/jira/browse/HIVE-27281?focusedWorklogId=859468&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-859468
 ]

ASF GitHub Bot logged work on HIVE-27281:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Apr/23 19:37
            Start Date: 27/Apr/23 19:37
    Worklog Time Spent: 10m 
      Work Description: difin commented on code in PR #4254:
URL: https://github.com/apache/hive/pull/4254#discussion_r1179603252


##########
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java:
##########
@@ -97,6 +101,8 @@ public CoreBeeLineDriver(AbstractCliConfig testCliConfig) {
       initScript = new File(testScriptDirectory, 
testCliConfig.getInitScript());
     }
     cleanupScript = new File(testScriptDirectory, 
testCliConfig.getCleanupScript());
+    this.replaceHandler = new QTestReplaceHandler();

Review Comment:
   As I understand form the code, QTestUtil can't be used as is because it 
doesn't execute commands using beeline.
   After digging into other drivers that use QTestUtil, I saw that QTestUtil 
executes commands from q-files using ReExecDriver.java which lives in hive-ql 
module, while CoreBeeLineDriver executes commands from q-files using 
Beeline.java. 





Issue Time Tracking
-------------------

    Worklog Id:     (was: 859468)
    Time Spent: 1h 20m  (was: 1h 10m)

> Add ability of masking to Beeline q-tests
> -----------------------------------------
>
>                 Key: HIVE-27281
>                 URL: https://issues.apache.org/jira/browse/HIVE-27281
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Dmitriy Fingerman
>            Assignee: Dmitriy Fingerman
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to