[
https://issues.apache.org/jira/browse/HIVE-27177?focusedWorklogId=856086&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-856086
]
ASF GitHub Bot logged work on HIVE-27177:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Apr/23 11:28
Start Date: 11/Apr/23 11:28
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #4155:
URL: https://github.com/apache/hive/pull/4155#discussion_r1162675048
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/convert/AlterTableConvertOperation.java:
##########
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.ddl.table.convert;
+
+import com.google.common.collect.ImmutableMap;
+import org.apache.hadoop.hive.ql.ddl.DDLOperationContext;
+import org.apache.hadoop.hive.ql.ddl.table.AbstractAlterTableOperation;
+import org.apache.hadoop.hive.ql.metadata.HiveException;
+import org.apache.hadoop.hive.ql.metadata.Partition;
+import org.apache.hadoop.hive.ql.metadata.Table;
+import org.apache.hadoop.hive.ql.parse.SemanticException;
+
+import java.util.Map;
+
+import static
org.apache.hadoop.hive.metastore.TransactionalValidationListener.DEFAULT_TRANSACTIONAL_PROPERTY;
+import static
org.apache.hadoop.hive.metastore.api.hive_metastoreConstants.META_TABLE_STORAGE;
+import static
org.apache.hadoop.hive.metastore.api.hive_metastoreConstants.TABLE_IS_TRANSACTIONAL;
+import static
org.apache.hadoop.hive.metastore.api.hive_metastoreConstants.TABLE_TRANSACTIONAL_PROPERTIES;
+
+/**
+ * Operation process of ALTER TABLE ... CONVERT command
+ */
+public class AlterTableConvertOperation extends
AbstractAlterTableOperation<AlterTableConvertDesc> {
+
+ private enum ConversionFormats {
+ ICEBERG(ImmutableMap.of(META_TABLE_STORAGE,
"org.apache.iceberg.mr.hive.HiveIcebergStorageHandler")),
+ ACID(ImmutableMap.of(TABLE_IS_TRANSACTIONAL, "true",
TABLE_TRANSACTIONAL_PROPERTIES,
+ DEFAULT_TRANSACTIONAL_PROPERTY));
+
+ private final Map<String, String> properties;
+
+ ConversionFormats(Map<String, String> properties) {
+ this.properties = properties;
+ }
+
+
+ public Map<String, String> properties() {
+ return properties;
+ }
+ }
+
+ public AlterTableConvertOperation(DDLOperationContext context,
AlterTableConvertDesc desc) {
+ super(context, desc);
+ }
+
+ @Override
+ protected void doAlteration(Table table, Partition partition) throws
HiveException {
+ // Add the covert type
+ String convertType = desc.getConvertSpec().getTargetType();
+ ConversionFormats format =
ConversionFormats.valueOf(convertType.toUpperCase());
Review Comment:
do we have any checks what type of tables we can migrate?
Issue Time Tracking
-------------------
Worklog Id: (was: 856086)
Time Spent: 3h (was: 2h 50m)
> Add alter table...Convert to Iceberg command
> --------------------------------------------
>
> Key: HIVE-27177
> URL: https://issues.apache.org/jira/browse/HIVE-27177
> Project: Hive
> Issue Type: Improvement
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Add an alter table <tblName> convert to Iceberg [TBLPROPERTIES('','')] to
> convert exiting external tables to iceberg tables
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
