[ https://issues.apache.org/jira/browse/HIVE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14998029#comment-14998029 ]
Hive QA commented on HIVE-12373: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12771471/HIVE-12373.1.patch.txt {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 27 failed/errored test(s), 9779 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_uri_import org.apache.hadoop.hive.hwi.TestHWISessionManager.testHiveDriver org.apache.hadoop.hive.metastore.hbase.TestHBaseStore.binaryPartitionStatistics org.apache.hadoop.hive.metastore.hbase.TestHBaseStore.booleanPartitionStatistics org.apache.hadoop.hive.metastore.hbase.TestHBaseStore.createTable org.apache.hadoop.hive.metastore.hbase.TestHBaseStore.decimalPartitionStatistics org.apache.hadoop.hive.metastore.hbase.TestHBaseStore.doublePartitionStatistics org.apache.hadoop.hive.metastore.hbase.TestHBaseStore.longPartitionStatistics org.apache.hadoop.hive.metastore.hbase.TestHBaseStore.stringPartitionStatistics org.apache.hadoop.hive.ql.parse.TestUpdateDeleteSemanticAnalyzer.testDeleteAllNonPartitioned org.apache.hadoop.hive.ql.parse.TestUpdateDeleteSemanticAnalyzer.testDeleteAllPartitioned org.apache.hadoop.hive.ql.parse.TestUpdateDeleteSemanticAnalyzer.testDeleteAllWherePartitioned org.apache.hadoop.hive.ql.parse.TestUpdateDeleteSemanticAnalyzer.testDeleteOnePartition org.apache.hadoop.hive.ql.parse.TestUpdateDeleteSemanticAnalyzer.testDeleteOnePartitionWhere org.apache.hadoop.hive.ql.parse.TestUpdateDeleteSemanticAnalyzer.testDeleteWhereNoPartition org.apache.hadoop.hive.ql.parse.TestUpdateDeleteSemanticAnalyzer.testInsertSelect org.apache.hadoop.hive.ql.parse.TestUpdateDeleteSemanticAnalyzer.testInsertValues org.apache.hadoop.hive.ql.parse.TestUpdateDeleteSemanticAnalyzer.testInsertValuesPartitioned org.apache.hadoop.hive.ql.parse.TestUpdateDeleteSemanticAnalyzer.testUpdateAllNonPartitioned org.apache.hadoop.hive.ql.parse.TestUpdateDeleteSemanticAnalyzer.testUpdateAllNonPartitionedWhere org.apache.hadoop.hive.ql.parse.TestUpdateDeleteSemanticAnalyzer.testUpdateAllPartitioned org.apache.hadoop.hive.ql.parse.TestUpdateDeleteSemanticAnalyzer.testUpdateAllPartitionedWhere org.apache.hadoop.hive.ql.parse.TestUpdateDeleteSemanticAnalyzer.testUpdateOnePartition org.apache.hadoop.hive.ql.parse.TestUpdateDeleteSemanticAnalyzer.testUpdateOnePartitionWhere org.apache.hadoop.hive.ql.security.TestStorageBasedClientSideAuthorizationProvider.testSimplePrivileges org.apache.hive.jdbc.TestMultiSessionsHS2WithLocalClusterSpark.testSparkQuery org.apache.hive.jdbc.TestSSL.testSSLVersion {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5980/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5980/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-5980/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 27 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12771471 - PreCommit-HIVE-TRUNK-Build > Interner should return identical map or list > -------------------------------------------- > > Key: HIVE-12373 > URL: https://issues.apache.org/jira/browse/HIVE-12373 > Project: Hive > Issue Type: Bug > Components: Query Processor > Reporter: Navis > Assignee: Navis > Priority: Minor > Attachments: HIVE-12373.1.patch.txt > > > Currently, HiveStringUtils.intern(map/list) returns new instance of map or > list. But it would break some usage style of code something like below (it's > spark code in HiveMetastoreCatalog) > {code} > val serdeParameters = new java.util.HashMap[String, String]() > serdeInfo.setParameters(serdeParameters) > // these properties will be gone > table.serdeProperties.foreach { case (k, v) => serdeParameters.put(k, v) } > p.storage.serdeProperties.foreach { case (k, v) => serdeParameters.put(k, v) } > {code} > Luckily for spark, interner was not applied to released version of hive > (1.2.0, 1.2.1) by mistake. But it would make problem in someday. -- This message was sent by Atlassian JIRA (v6.3.4#6332)