[
https://issues.apache.org/jira/browse/HIVE-27020?focusedWorklogId=855788&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-855788
]
ASF GitHub Bot logged work on HIVE-27020:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Apr/23 12:00
Start Date: 10/Apr/23 12:00
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #4091:
URL: https://github.com/apache/hive/pull/4091#discussion_r1161665575
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/handler/TaskHandlerFactory.java:
##########
@@ -43,7 +44,14 @@ private TaskHandlerFactory() {
public List<TaskHandler> getHandlers(HiveConf conf, TxnStore txnHandler,
MetadataCache metadataCache,
boolean metricsEnabled,
FSRemover fsRemover) {
- return Arrays.asList(new CompactionCleaner(conf, txnHandler, metadataCache,
+ boolean useAbortHandler = MetastoreConf.getBoolVar(conf,
MetastoreConf.ConfVars.COMPACTOR_CLEAN_ABORTS_USING_CLEANER);
+ List<TaskHandler> taskHandlers = new ArrayList<>();
+ if (useAbortHandler) {
Review Comment:
no need for that check, from now on use Cleaner to handle aborts
Issue Time Tracking
-------------------
Worklog Id: (was: 855788)
Time Spent: 9h 50m (was: 9h 40m)
> Implement a separate handler to handle aborted transaction cleanup
> ------------------------------------------------------------------
>
> Key: HIVE-27020
> URL: https://issues.apache.org/jira/browse/HIVE-27020
> Project: Hive
> Issue Type: Sub-task
> Reporter: Sourabh Badhya
> Assignee: Sourabh Badhya
> Priority: Major
> Labels: pull-request-available
> Time Spent: 9h 50m
> Remaining Estimate: 0h
>
> As described in the parent task, once the cleaner is separated into different
> entities, implement a separate handler which can create requests for aborted
> transactions cleanup. This would move the aborted transaction cleanup
> exclusively to the cleaner.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
