[ https://issues.apache.org/jira/browse/HIVE-27179?focusedWorklogId=853826&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-853826 ]
ASF GitHub Bot logged work on HIVE-27179: ----------------------------------------- Author: ASF GitHub Bot Created on: 30/Mar/23 04:12 Start Date: 30/Mar/23 04:12 Worklog Time Spent: 10m Work Description: saihemanth-cloudera commented on code in PR #4164: URL: https://github.com/apache/hive/pull/4164#discussion_r1152709966 ########## service/src/java/org/apache/hive/service/server/HiveServer2.java: ########## @@ -133,6 +133,8 @@ import com.google.common.util.concurrent.SettableFuture; import com.google.common.util.concurrent.ThreadFactoryBuilder; +import javax.servlet.jsp.JspFactory; Review Comment: I see that you have removed javax.servlet dependency from root and service's pom.xml. I'm wondering where this dependency is coming from. Issue Time Tracking ------------------- Worklog Id: (was: 853826) Time Spent: 40m (was: 0.5h) > HS2 WebUI throws NPE when JspFactory loaded from jetty-runner > ------------------------------------------------------------- > > Key: HIVE-27179 > URL: https://issues.apache.org/jira/browse/HIVE-27179 > Project: Hive > Issue Type: Bug > Components: HiveServer2 > Reporter: Zhihua Deng > Priority: Major > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > In HIVE-17088{*},{*} we resolved a NPE thrown from HS2 WebUI by introducing > javax.servlet.jsp-api. It works as expected when the javax.servlet.jsp-api > jar prevails jetty-runner jar, but things can be different in some > environments, it still throws NPE when opening the HS2 web: > {noformat} > java.lang.NullPointerException > at > org.apache.hive.generated.hiveserver2.hiveserver2_jsp._jspService(hiveserver2_jsp.java:286) > > at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:71) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) > at > org.eclipse.jetty.servlet.ServletHolder$NotAsync.service(ServletHolder.java:1443) > > at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:791) > at > org.eclipse.jetty.servlet.ServletHandler$ChainEnd.doFilter(ServletHandler.java:1626) > ...{noformat} > The jetty-runner JspFactory.getDefaultFactory() just returns null. -- This message was sent by Atlassian Jira (v8.20.10#820010)