[ 
https://issues.apache.org/jira/browse/HIVE-27158?focusedWorklogId=853126&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-853126
 ]

ASF GitHub Bot logged work on HIVE-27158:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Mar/23 10:28
            Start Date: 27/Mar/23 10:28
    Worklog Time Spent: 10m 
      Work Description: deniskuzZ commented on code in PR #4131:
URL: https://github.com/apache/hive/pull/4131#discussion_r1149111504


##########
ql/src/java/org/apache/hadoop/hive/ql/stats/ColStatsProcessor.java:
##########
@@ -218,6 +218,9 @@ public int persistColumnStats(Hive db, Table tbl) throws 
HiveException, MetaExce
       }
 
       start = System. currentTimeMillis();
+      if(tbl != null && tbl.isNonNative() && 
tbl.getStorageHandler().canSetColStatistics()){
+       tbl.getStorageHandler().setColStatistics(tbl, colStats);

Review Comment:
   when this code is getting invoked, is it by auto-gather thread? if yes, what 
if there was several snapshots generated between the runs? 



##########
ql/src/java/org/apache/hadoop/hive/ql/stats/ColStatsProcessor.java:
##########
@@ -218,6 +218,9 @@ public int persistColumnStats(Hive db, Table tbl) throws 
HiveException, MetaExce
       }
 
       start = System. currentTimeMillis();
+      if(tbl != null && tbl.isNonNative() && 
tbl.getStorageHandler().canSetColStatistics()){
+       tbl.getStorageHandler().setColStatistics(tbl, colStats);

Review Comment:
   when this code is getting invoked, is it by auto-gather thread? if yes, what 
if there were several snapshots generated between the runs? 





Issue Time Tracking
-------------------

    Worklog Id:     (was: 853126)
    Time Spent: 5h 50m  (was: 5h 40m)

> Store hive columns stats in puffin files for iceberg tables
> -----------------------------------------------------------
>
>                 Key: HIVE-27158
>                 URL: https://issues.apache.org/jira/browse/HIVE-27158
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Simhadri Govindappa
>            Assignee: Simhadri Govindappa
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 5h 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to